96547[TASK] Update enshrined/svg-sanitize to ^1.0
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
-
Verified V +2 Done
- Benni Mack +2
- Lina Wolf +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/CleanSVG/entity.svg+0 −4
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/CleanSVG/entity_2.svg+0 −4
- typo3/sysext/core/Tests/Functional/Resource/Security/SvgSanitizerTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Imaging/Svg/SvgDocumentFactoryTest.php+15 −3
- typo3/sysext/core/composer.json+1 −1
- composer.json+1 −1
- composer.lock+7 −7
Review log 68
-
Benjamin Franzke uploaded patch set 1 10/09/26, 07:53
-
core-ci voted on patch set 1 V +1 10/09/26, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110558
-
Benjamin Franzke uploaded patch set 2
V +110/09/26, 08:03 -
Benjamin Franzke updated the commit message in patch set 3 10/09/26, 08:05
-
core-ci voted on patch set 3 V +1 10/09/26, 08:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110560
-
Benni Mack voted on patch set 3 CR +2 V +2 10/09/26, 08:29
-
Benni Mack merged patch set 4 10/09/26, 08:29
-
Lina Wolf commented on patch set 4 V +1 10/09/26, 08:48
Tested on main (5c6c29826fc) with svg-sanitize 1.0.0: SVG unit and functional tests pass, and all 881 SVGs shipped by the core sanitize byte-identical to 0.22. One behaviour change is not in the commit message: with removeRemoteReferences(true), 1.0 also removes remote URLs from <image href="https://…">, which 0.22 kept. SVGs that embed an external bitmap lose that image after the update. Relative links, # references, and data: images are still kept.