Review main Merged

96558[BUGFIX] Propagate CSV download response in QuerySearchController

Benni Mack CR +2 V +2 Easy +33 −7 updated 10/09/26, 14:53

Commit message

The CSV export of the database query module sent raw header()
calls, echoed the file content and terminated the request with
die, bypassing the PSR-15 middleware stack.

The download is now built as a PSR-7 response and handed back via
PropagateResponseException, like other backend download
controllers do.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Wouter Wolters +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Benni Mack uploaded patch set 1 10/09/26, 10:48

  2. Wouter Wolters voted on patch set 1 CR +1 V +1 10/09/26, 10:53

  3. core-ci voted on patch set 1 V -1 10/09/26, 11:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110589

  4. Benni Mack rebased onto patch set 2 CR +1 V +1 10/09/26, 13:19

  5. core-ci voted on patch set 2 V +1 10/09/26, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110613

  6. Josua Vogel voted on patch set 2 CR +1 V +1 10/09/26, 13:52

  7. Oliver Klee voted on patch set 2 V +1 10/09/26, 14:14

  8. Wouter Wolters voted on patch set 2 CR +1 V +1 10/09/26, 14:26

  9. Garvin Hicking voted on patch set 2 CR +2 V +2 10/09/26, 14:53

  10. Garvin Hicking merged patch set 3 10/09/26, 14:53