Review main Merged

96562[BUGFIX] Keep excluded unique values when moving records

Benni Mack CR +2 V +2 Normal +101 −13 updated 10/12/26, 19:57

Commit message

Moving or sorting a record re-evaluates "uniqueInPid" through
fixUniqueInPid(). getUnique() then read the translation and
version information from checkValue_currentRecord, which still
held the previously processed record. A moved translation was
treated as a default language record, and the value of a field
with l10n_mode=exclude got a counter appended, although it has
to equal the value of its default language record.

In workspaces, creating the version of a default language record
compared the translation pointer of other records against the
not yet existing uid of the version, while translations point to
the live record. The default language record was renamed as soon
as a translation existed.

fixUniqueInPid() now hands the moved record to getUnique(), and
the lookup ignores translations of the live record.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 67

  1. Benni Mack uploaded patch set 1 10/09/26, 13:18

  2. core-ci voted on patch set 1 V +1 10/09/26, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110612

  3. Simon Schaufelberger voted on patch set 1 CR +1 V +1 10/12/26, 14:23

  4. Oliver Klee voted on patch set 1 V +1 10/12/26, 14:47

  5. Wouter Wolters voted on patch set 1 CR +1 V +1 10/12/26, 17:33

  6. Georg Ringer voted on patch set 1 CR +2 V +2 10/12/26, 19:57

  7. Georg Ringer merged patch set 2 10/12/26, 19:57