Review main Merged

96564[FEATURE] Filter the form list by storage location

Josua Vogel CR +2 V +2 Hard +351 −72 updated 11/20/26, 21:46

Commit message

The form manager lists the forms of every storage in one table, so
finding the forms of one location means scanning the whole list.

A "Location" filter is added next to the search field. Forms stored in
extensions are grouped by their folder, forms stored in the database
are one location. The filter is kept across pagination, sorting and
the module shortcut, and is laid out like the filter forms of other
backend modules.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Maike Kiebele +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 2437

Show 812 earlier messages
  1. Josua Vogel uploaded patch set 1 10/09/26, 15:44

  2. core-ci voted on patch set 1 V -1 10/09/26, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110620

  3. Josua Vogel uploaded patch set 2 V -1 10/09/26, 16:03

  4. Josua Vogel uploaded patch set 3 10/09/26, 16:11

  5. core-ci voted on patch set 2 V -1 10/09/26, 16:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110621

  6. core-ci voted on patch set 3 V +1 10/09/26, 16:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110624

  7. Josua Vogel rebased onto patch set 4 V +1 10/10/26, 12:10

  8. core-ci voted on patch set 4 V +1 10/10/26, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110802

  9. Mathias Brodala commented on patch set 4 10/12/26, 07:09

    Feature-89760-FilterTheFormListByStorageLocation.rst:22

    Correct but confusing in this context. ;-) Let's use "are".

    FormMetadata.php:103

    Missing nullsafe ?-> access here since $this->storageLocation is nullable. If we guarantee that it is always present, the type should not be nullable anymore.

    DatabaseStorageAdapter.php:269

    How about moving this INTO getStorageLocationLabel() instead? Or would it be bad if this was used everywhere else like getFormManagerOptions() below?
  10. Josua Vogel commented on patch set 4 10/12/26, 08:08

    FormMetadata.php:103 Reply

    ?? is null-safe for the whole chain on its left. PHPStan even rejects ?-> here as unnecessary (nullsafe.neverNull
  11. Josua Vogel uploaded patch set 5 V +1 10/12/26, 08:12

  12. Josua Vogel commented on patch set 5 10/12/26, 08:13

    Feature-89760-FilterTheFormListByStorageLocation.rst:22 Reply

    Done

    DatabaseStorageAdapter.php:269 Reply

    Done
  1. Mathias Brodala commented on patch set 5 10/12/26, 08:14

    FormMetadata.php:103 Reply

    Didn't know this, thanks!
  2. core-ci voted on patch set 5 V +1 10/12/26, 08:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110890

  3. Maike Kiebele voted on patch set 5 V +1 10/14/26, 07:33

  4. Josua Vogel uploaded patch set 6 V +1 10/14/26, 07:49

  5. Maike Kiebele voted on patch set 6 V +1 10/14/26, 07:52

  6. core-ci voted on patch set 6 V +1 10/14/26, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111052

  7. Guido Schmechel commented on patch set 6 10/16/26, 10:03

    You hide the location filter when there are no options available. Doesn't it make sense, then, to hide the location information in the table as well?
  8. Josua Vogel uploaded patch set 7 V +1 10/23/26, 12:21

  9. Josua Vogel commented on patch set 7 10/23/26, 12:24

    Reply

    I wouldn´t change the table - just to be consistent. EXT:redirects always shows its source host column as well.
  10. core-ci voted on patch set 7 V +1 10/23/26, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112295

  11. Josua Vogel rebased onto patch set 8 V +1 10/26/26, 07:42

  12. core-ci voted on patch set 8 V +1 10/26/26, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112575

  13. Josua Vogel uploaded patch set 9 V +1 11/06/26, 07:43

  14. core-ci voted on patch set 9 V -1 11/06/26, 07:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113461

  15. Josua Vogel rebased onto patch set 10 V -1 11/06/26, 08:51

  16. core-ci voted on patch set 10 V -1 11/06/26, 09:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113467

  17. core-ci voted on patch set 10 V +1 11/06/26, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113467

  18. Josua Vogel rebased onto patch set 11 V +1 11/11/26, 16:12

  19. core-ci voted on patch set 11 V +1 11/11/26, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114125

  20. Josua Vogel rebased onto patch set 12 V +1 11/14/26, 17:59

  21. core-ci voted on patch set 12 V +1 11/14/26, 18:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114481

  22. Maike Kiebele voted on patch set 12 V +1 11/19/26, 08:42

  23. Garvin Hicking voted on patch set 12 CR +1 V +1 11/20/26, 14:28

  24. Georg Ringer voted on patch set 12 CR +2 V +2 11/20/26, 21:46

  25. Georg Ringer merged patch set 13 11/20/26, 21:46