96564[FEATURE] Filter the form list by storage location
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Garvin Hicking +1
-
Verified V +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- Maike Kiebele +1
- core-ci +1 CI
Issues 1
Files 18
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-89760-FilterTheFormListByStorageLocation.rst2new+39 −0
- typo3/sysext/form/Classes/Controller/FormManagerController.php+62 −3
- typo3/sysext/form/Classes/Domain/DTO/FormMetadata.php3+6 −4
- typo3/sysext/form/Classes/Domain/DTO/StorageLocation.phpnew+31 −0
- typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManager.php+4 −0
- typo3/sysext/form/Classes/Storage/AbstractFileStorageAdapter.php+0 −6
- typo3/sysext/form/Classes/Storage/DatabaseStorageAdapter.php2+6 −5
- typo3/sysext/form/Classes/Storage/ExtensionStorageAdapter.php+7 −14
- typo3/sysext/form/Documentation/I/Concepts/FormManager/Index.rst+12 −0
- typo3/sysext/form/Resources/Private/Language/Database.xlf+17 −2
- typo3/sysext/form/Resources/Private/Partials/Backend/FormManager/Pagination.fluid.html+6 −6
- typo3/sysext/form/Resources/Private/Templates/Backend/FormManager/Index.fluid.html+45 −30
- typo3/sysext/form/Tests/Functional/Controller/FormManagerControllerTest.php+44 −0
- typo3/sysext/form/Tests/Functional/Fixtures/Extensions/form_storage_tests/Configuration/Form/Base/config.yaml+1 −0
- typo3/sysext/form/Tests/Functional/Fixtures/Extensions/form_storage_tests/Resources/Private/Forms/Special/SpecialForm.form.yamlnew+3 −0
- typo3/sysext/form/Tests/Functional/Mvc/Persistence/FormPersistenceManagerTest.php+21 −0
- typo3/sysext/form/Tests/Functional/Storage/DatabaseStorageAdapterFunctionalTest.php+12 −0
- typo3/sysext/form/Tests/Functional/Storage/ExtensionStorageAdapterFunctionalTest.php+35 −2
Review log 2437
Show 812 earlier messages
-
Josua Vogel uploaded patch set 1 10/09/26, 15:44
-
core-ci voted on patch set 1 V -1 10/09/26, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110620
-
Josua Vogel uploaded patch set 2
V -110/09/26, 16:03 -
Josua Vogel uploaded patch set 3 10/09/26, 16:11
-
core-ci voted on patch set 2 V -1 10/09/26, 16:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110621
-
core-ci voted on patch set 3 V +1 10/09/26, 16:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110624
-
Josua Vogel rebased onto patch set 4
V +110/10/26, 12:10 -
core-ci voted on patch set 4 V +1 10/10/26, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110802
-
Mathias Brodala commented on patch set 4 10/12/26, 07:09
FormMetadata.php:103Missing nullsafe ?-> access here since $this->storageLocation is nullable. If we guarantee that it is always present, the type should not be nullable anymore.DatabaseStorageAdapter.php:269How about moving this INTO getStorageLocationLabel() instead? Or would it be bad if this was used everywhere else like getFormManagerOptions() below? -
Josua Vogel commented on patch set 4 10/12/26, 08:08
FormMetadata.php:103Reply?? is null-safe for the whole chain on its left. PHPStan even rejects ?-> here as unnecessary (nullsafe.neverNull -
Josua Vogel uploaded patch set 5
V +110/12/26, 08:12 -
Josua Vogel commented on patch set 5 10/12/26, 08:13
Feature-89760-FilterTheFormListByStorageLocation.rst:22ReplyDoneDatabaseStorageAdapter.php:269ReplyDone
-
Mathias Brodala commented on patch set 5 10/12/26, 08:14
FormMetadata.php:103ReplyDidn't know this, thanks! -
core-ci voted on patch set 5 V +1 10/12/26, 08:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110890
-
Maike Kiebele voted on patch set 5 V +1 10/14/26, 07:33
-
Josua Vogel uploaded patch set 6
V +110/14/26, 07:49 -
Maike Kiebele voted on patch set 6 V +1 10/14/26, 07:52
-
core-ci voted on patch set 6 V +1 10/14/26, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111052
-
Guido Schmechel commented on patch set 6 10/16/26, 10:03
You hide the location filter when there are no options available. Doesn't it make sense, then, to hide the location information in the table as well? -
Josua Vogel uploaded patch set 7
V +110/23/26, 12:21 -
Josua Vogel commented on patch set 7 10/23/26, 12:24
Reply
I wouldn´t change the table - just to be consistent. EXT:redirects always shows its source host column as well. -
core-ci voted on patch set 7 V +1 10/23/26, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112295
-
Josua Vogel rebased onto patch set 8
V +110/26/26, 07:42 -
core-ci voted on patch set 8 V +1 10/26/26, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112575
-
Josua Vogel uploaded patch set 9
V +111/06/26, 07:43 -
core-ci voted on patch set 9 V -1 11/06/26, 07:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113461
-
Josua Vogel rebased onto patch set 10
V -111/06/26, 08:51 -
core-ci voted on patch set 10 V -1 11/06/26, 09:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113467
-
core-ci voted on patch set 10 V +1 11/06/26, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113467
-
Josua Vogel rebased onto patch set 11
V +111/11/26, 16:12 -
core-ci voted on patch set 11 V +1 11/11/26, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114125
-
Josua Vogel rebased onto patch set 12
V +111/14/26, 17:59 -
core-ci voted on patch set 12 V +1 11/14/26, 18:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114481
-
Maike Kiebele voted on patch set 12 V +1 11/19/26, 08:42
-
Garvin Hicking voted on patch set 12 CR +1 V +1 11/20/26, 14:28
-
Georg Ringer voted on patch set 12 CR +2 V +2 11/20/26, 21:46
-
Georg Ringer merged patch set 13 11/20/26, 21:46
Feature-89760-FilterTheFormListByStorageLocation.rst:22