Review main Merged

96572[BUGFIX] Show failed files in the extension scanner

Georg Ringer CR +2 V +2 Hard +183 −97 updated 11/18/26, 08:14

Commit message

When the scan request for a single file failed, the extension scanner
counted the file as checked and logged the reason to the browser
console only. The panel showed "Checked N of N files" and could even
turn green although the hits of that file were missing.

Failed files are now counted separately in the status message, listed
in the result of the extension and mark its panel as failed. A
response with success=false is treated the same way.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1114

  1. Georg Ringer uploaded patch set 1 10/09/26, 18:47

  2. Georg Ringer commented on patch set 1 10/09/26, 18:47

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/09/26, 18:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110690

  4. Georg Ringer uploaded patch set 2 V +1 10/24/26, 06:26

  5. core-ci voted on patch set 2 V +1 10/24/26, 06:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112395

  6. Benni Mack voted on patch set 2 CR +1 V +1 10/28/26, 08:09

  7. Oli Bartsch commented on patch set 2 CR -1 10/28/26, 08:55

    extension-scanner.ts:165

    "Scan all" still marks changelog files as not affected when files failed. `failedFiles` is local to `scanSingleExtension()`, so `scanAll()` always shows the success notification and posts `extensionScannerMarkFullyScannedRestFiles`. A file that fails to parse can then end up as "not affected" in Upgrade Docs. Please return the failed count from `scanSingleExtension()` (or keep a modal-level flag), and if any file failed, skip the mark request and show a warning instead of "All extensions have been scanned.".

    extension-scanner.ts:274

    if the `onfulfilled` handler fails, neither `resolve` nor `reject` runs and `Promise.allSettled` never settles, leaving the panel in progress and Rescan disabled. Suggest to wrap the body in `try/catch` that calls `markFileAsFailed(file)` and `resolve()`.

    extension-scanner.ts:284

    after the new early return for `success !== true`, the `fileData.success` checks are always true. Please drop that part. Also in Line 340.

    extension-scanner.ts:372

    the failure panel button still has `aria-expanded`, `aria-controls`/`data-bs-target` and the `collapsed` class, although the body is gone. Screen readers will announce a disclosure button that does nothing, so please remove those too (or use a small non-collapsible template in `ExtensionScanner.fluid.html`).
  8. Georg Ringer uploaded patch set 3 CR +1 V +1 11/03/26, 20:06

  9. Georg Ringer commented on patch set 3 11/03/26, 20:07

    extension-scanner.ts:165 Reply

    Done

    extension-scanner.ts:274 Reply

    Done

    extension-scanner.ts:284 Reply

    Done

    extension-scanner.ts:372 Reply

    Done
  10. core-ci voted on patch set 3 V +1 11/03/26, 20:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113217

  11. Benni Mack voted on patch set 3 CR +1 V +1 11/09/26, 20:45

  12. Simon Schaufelberger voted on patch set 3 CR +1 V +1 11/14/26, 20:36

  13. Georg Ringer voted on patch set 3 CR +2 V +2 11/18/26, 08:14

  14. Georg Ringer merged patch set 4 11/18/26, 08:14