96572[BUGFIX] Show failed files in the extension scanner
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benni Mack +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1114
-
Georg Ringer uploaded patch set 1 10/09/26, 18:47
-
Georg Ringer commented on patch set 1 10/09/26, 18:47
This change is ready for review. -
core-ci voted on patch set 1 V +1 10/09/26, 18:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110690
-
Georg Ringer uploaded patch set 2
V +110/24/26, 06:26 -
core-ci voted on patch set 2 V +1 10/24/26, 06:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112395
-
Benni Mack voted on patch set 2 CR +1 V +1 10/28/26, 08:09
-
Oli Bartsch commented on patch set 2 CR -1 10/28/26, 08:55
extension-scanner.ts:165"Scan all" still marks changelog files as not affected when files failed. `failedFiles` is local to `scanSingleExtension()`, so `scanAll()` always shows the success notification and posts `extensionScannerMarkFullyScannedRestFiles`. A file that fails to parse can then end up as "not affected" in Upgrade Docs. Please return the failed count from `scanSingleExtension()` (or keep a modal-level flag), and if any file failed, skip the mark request and show a warning instead of "All extensions have been scanned.".extension-scanner.ts:274if the `onfulfilled` handler fails, neither `resolve` nor `reject` runs and `Promise.allSettled` never settles, leaving the panel in progress and Rescan disabled. Suggest to wrap the body in `try/catch` that calls `markFileAsFailed(file)` and `resolve()`.extension-scanner.ts:284after the new early return for `success !== true`, the `fileData.success` checks are always true. Please drop that part. Also in Line 340.extension-scanner.ts:372the failure panel button still has `aria-expanded`, `aria-controls`/`data-bs-target` and the `collapsed` class, although the body is gone. Screen readers will announce a disclosure button that does nothing, so please remove those too (or use a small non-collapsible template in `ExtensionScanner.fluid.html`). -
Georg Ringer uploaded patch set 3
CR +1V +111/03/26, 20:06 -
Georg Ringer commented on patch set 3 11/03/26, 20:07
extension-scanner.ts:165ReplyDoneextension-scanner.ts:274ReplyDoneextension-scanner.ts:284ReplyDoneextension-scanner.ts:372ReplyDone -
core-ci voted on patch set 3 V +1 11/03/26, 20:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113217
-
Benni Mack voted on patch set 3 CR +1 V +1 11/09/26, 20:45
-
Simon Schaufelberger voted on patch set 3 CR +1 V +1 11/14/26, 20:36
-
Georg Ringer voted on patch set 3 CR +2 V +2 11/18/26, 08:14
-
Georg Ringer merged patch set 4 11/18/26, 08:14