96590[TASK] Deprecate Extbase controller actions as string
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Alexander Schnitzler +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Alexander Schnitzler +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/backend/Classes/Module/ExtbaseModule.php+13 −3
- typo3/sysext/backend/Tests/Unit/Module/ExtbaseModuleTest.phpnew+74 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Deprecation-110994-ExtbaseControllerActionsAsCommaSeparatedString.rstnew+85 −0
- typo3/sysext/extbase/Classes/Utility/ExtensionUtility.php+9 −2
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/extbase_upload/ext_localconf.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Mvc/Web/RequestBuilderTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Utility/ExtensionUtilityTest.php+57 −0
Review log 911
-
Torben Hansen uploaded patch set 1 10/10/26, 08:02
-
Wolfgang Klinger commented on patch set 1 CR +1 V +1 10/10/26, 08:14
Looks good. One suggestion: the new deprecation branch in ExtbaseModule::sanitizeControllerActions() has no test, while the two configurePlugin() branches do. A small unit test for ExtbaseModule::createFromConfiguration() with a comma-separated string, same style as the new ExtensionUtility tests, would make the three paths consistent. -
core-ci voted on patch set 1 V -1 10/10/26, 08:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110768
-
Torben Hansen uploaded patch set 2
CR +1V +110/10/26, 08:43 -
Torben Hansen commented on patch set 2 10/10/26, 08:43
Reply
done -
core-ci voted on patch set 2 V +1 10/10/26, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110772
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 10/10/26, 09:00
-
Alexander Schnitzler voted on patch set 2 CR +1 V +1 10/17/26, 06:24
-
Oliver Klee voted on patch set 2 CR +1 V +1 10/17/26, 17:05
-
Georg Ringer voted on patch set 2 CR +2 V +2 10/23/26, 15:56
-
Georg Ringer merged patch set 3 10/23/26, 15:56