Review main Merged

96594[BUGFIX] Resolve dependencies of the native "discard" command

Benni Mack CR +2 V +2 Hard +289 −14 updated 10/12/26, 19:46

Commit message

The workspace dependency resolution for discarding collected native
"discard" commands, but rebuilt the command map only in the legacy
format ("version" with action "clearWSID" / "flush"). Since a native
"discard" carries no "action", every element of a dependency
structure received an empty "version" command, which does nothing.

As a result, discarding the inline child of a record deleted in a
workspace left the parent's delete placeholder behind, PHP warnings
about the missing "action" key were raised, and processCmdmap hooks
received empty "version" commands, requested records even a second
one next to their "discard" command.

Every element now keeps the command format it was requested with,
dependent elements take the format of the requested element, and
other "version" actions in the same command map stay untouched.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2

Issues 1

Files 2

Review log 711

  1. Benni Mack uploaded patch set 1 10/10/26, 10:18

  2. core-ci voted on patch set 1 V -1 10/10/26, 10:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110791

  3. core-ci voted on patch set 1 V +1 10/10/26, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110791

  4. Oli Bartsch uploaded patch set 2 V +1 10/10/26, 10:47

  5. core-ci voted on patch set 2 V +1 10/10/26, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110793

  6. Oli Bartsch voted on patch set 2 CR +1 V +1 10/10/26, 16:52

  7. Wouter Wolters voted on patch set 2 CR +1 V +1 10/12/26, 18:35

  8. Georg Ringer uploaded patch set 3 CR +1 V +1 10/12/26, 19:08

  9. Georg Ringer voted on patch set 3 CR +2 V +2 10/12/26, 19:16

  10. Georg Ringer merged patch set 4 10/12/26, 19:16

  11. core-ci voted on patch set 3 V +1 10/12/26, 19:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110924