Review 14.3 Merged

96596[BUGFIX] Fix backend live search crash for users without page mounts

Oli Bartsch CR +2 V +2 Normal +205 −4 updated 10/10/26, 16:51

Commit message

The backend live search providers `DatabaseRecordProvider` and
`PageRecordProvider` only restrict the query to accessible pages
when the resolved page-id list is not empty. `getPageIdList()`
returns an empty list both for admins (search everything) and
for a non-admin without page mounts, without distinguishing the
two.

Furthermore, for a non-admin without page mounts,
`getPageIdList()` passes an empty entry point list to
`PageTreeRepository::getFlattenedPages()`, which then returns all
pages the user has show permission on, regardless of page mounts.

Such a user therefore searches pages outside their page mounts,
and `getEditActionLink()` passes an empty page record to
`calcPerms()`, which throws exception 1578950324 ("The given page
record is invalid. Missing uid."). Live search is thus unusable
for any backend user without page mounts.

The unrestricted branch is now reserved for admins. A non-admin
user without page mounts has access to no pages and receives no
results. `PageRecordProvider::count()` now also builds the
page-id list, so the count path is restricted consistently with
`find()`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 6

Review log 34

  1. Oli Bartsch uploaded patch set 1 10/10/26, 10:57

  2. core-ci voted on patch set 1 V +1 10/10/26, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110797

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 10/10/26, 16:51

  4. Oli Bartsch merged patch set 2 10/10/26, 16:51