Review main Merged

96604[BUGFIX] Escape the record edit document title only once

Wolfgang Klinger CR +2 V +2 Easy +20 −2 updated 10/17/26, 13:53

Commit message

The document title of the record edit form was escaped in
EditDocumentController and again by PageRenderer for the
<title> tag and by the bookmark button for its display-name
attribute. Titles with special characters like "&" showed
up as "&amp;" in the browser tab and in bookmarks.

The controller now hands over the plain title and leaves
escaping to the rendering layer.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Guido Schmechel +1
    • Wouter Wolters +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Guido Schmechel +1
    • Wouter Wolters +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 89

  1. Wolfgang Klinger uploaded patch set 1 10/11/26, 10:00

  2. core-ci voted on patch set 1 V +1 10/11/26, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110844

  3. Guido Schmechel voted on patch set 1 CR +1 V +1 10/12/26, 17:36

  4. Georg Ringer voted on patch set 1 CR +1 V +1 10/12/26, 18:33

  5. Simon Schaufelberger voted on patch set 1 CR +1 V +1 10/13/26, 08:30

  6. Wouter Wolters voted on patch set 1 CR +1 V +1 10/14/26, 16:44

  7. Oli Bartsch commented on patch set 1 CR -2 10/17/26, 11:07

    Unresolved

    Reviewing this. (t3cb)
  8. Oli Bartsch voted on patch set 1 CR +2 V +2 10/17/26, 13:53

  9. Oli Bartsch merged patch set 2 10/17/26, 13:53