96605[BUGFIX] Stop probing settings once the tree is empty
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
-
Verified V +2 Done
- Oli Bartsch +2
- core-ci +1 CI
Issues 2
Files 2
Review log 1317
-
Wolfgang Klinger uploaded patch set 1 10/11/26, 10:43
-
core-ci voted on patch set 1 V +1 10/11/26, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110846
-
Wouter Wolters commented on patch set 1 CR +1 V +1 10/13/26, 17:33
It works but maybe we can have this improvement in the ArrayUtility it self. Seems way faster that way and other can benefit too. -
Wouter Wolters commented on patch set 1 10/13/26, 17:50
Reply
-
Wolfgang Klinger uploaded patch set 2
CR +1V +110/14/26, 08:22 -
Wolfgang Klinger commented on patch set 2 10/14/26, 08:23
Thanks @typo3@wouterwolters.nl, agreed, the exception in isValidPath() should go, and your change is the right place for that. I measured both with 200 sites. Your change alone brings this method from 1.4 s to 0.7 s, because the loop still probes every definition for every set and site. The real cost is the loop, so I reduced this patch to one thing: stop as soon as the tree is empty. That gives 50 ms for map notation and 280 ms for tree notation on its own, about 170 ms for tree notation together with yours. The first-segment guard I had is gone, your change covers that. ArrayUtility is identical on 13.4 and 14.3, so yours can go to all three branches as well. -
Wouter Wolters voted on patch set 2 CR +1 V +1 10/14/26, 08:29
-
core-ci voted on patch set 2 V +1 10/14/26, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111056
-
Oliver Klee voted on patch set 2 CR +1 V +1 10/21/26, 20:48
-
Oli Bartsch commented on patch set 2 10/22/26, 06:40
Not a priority bugfix. -
Wolfgang Klinger rebased onto patch set 3
CR +1V +110/22/26, 06:42 -
core-ci voted on patch set 3 V +1 10/22/26, 06:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112065
-
Oli Bartsch uploaded patch set 4
V +110/22/26, 07:18 -
Oli Bartsch commented on patch set 4 CR +1 V +1 10/22/26, 07:18
Reply
Done -
core-ci voted on patch set 4 V +1 10/22/26, 07:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112067
-
Oli Bartsch voted on patch set 4 CR +2 V +2 10/22/26, 07:48
-
Oli Bartsch merged patch set 5 10/22/26, 07:48