Review main Merged

96613[TASK] Restore environment variables after tests

Wouter Wolters CR +2 V +2 Easy +14 −14 updated 10/12/26, 18:19

Commit message

Use PHPUnit's WithEnvironmentVariable attribute to restore the previous
process environment after each test. Replace the renderer's dynamic
environment variable with a fixed test fixture.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Josua Vogel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Josua Vogel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 67

  1. Wouter Wolters uploaded patch set 1 10/11/26, 14:18

  2. Oliver Klee voted on patch set 1 CR +1 V +1 10/11/26, 14:23

  3. core-ci voted on patch set 1 V +1 10/11/26, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110860

  4. Josua Vogel voted on patch set 1 CR +1 V +1 10/11/26, 14:45

  5. Simon Schaufelberger voted on patch set 1 CR +1 V +1 10/12/26, 00:27

  6. Georg Ringer voted on patch set 1 CR +2 V +2 10/12/26, 18:19

  7. Georg Ringer merged patch set 2 10/12/26, 18:19