Review main Merged

96614[TASK] Restore locale categories after unit tests

Wouter Wolters CR +2 V +2 Easy +15 −13 updated 10/14/26, 08:51

Commit message

Save and restore each locale category independently in the site
resolver and locale tests. Include LC_CTYPE, which the locale setter
also changes, to preserve the process locale between tests.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 910

  1. Wouter Wolters uploaded patch set 1 10/11/26, 17:07

  2. Wouter Wolters rebased onto patch set 2 10/13/26, 18:25

  3. Wouter Wolters wrote 10/13/26, 18:25

    Unset private
  4. core-ci voted on patch set 2 V +1 10/13/26, 18:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111019

  5. Simon Schaufelberger voted on patch set 2 CR +1 V +1 10/13/26, 20:03

  6. Simon Schaufelberger commented on patch set 2 10/13/26, 20:04

    Worth a backport or not?
  7. Wouter Wolters commented on patch set 2 10/13/26, 20:24

    Reply

    In all these years this survived. It is more a cleanup than a real fix IMO
  8. Simon Schaufelberger commented on patch set 2 10/13/26, 20:26

    Reply

    Done
  9. Benni Mack voted on patch set 2 CR +2 V +2 10/14/26, 08:51

  10. Benni Mack merged patch set 3 10/14/26, 08:51