Review main Merged

96615[TASK] Require QueryBuilder delegation in unit tests

Wouter Wolters CR +2 V +2 Easy +4 −4 updated 10/14/26, 11:18

Commit message

Require exactly one delegation call for delete, update, insert and
from. The previous expectations allowed zero calls, so the tests passed
when delegation was removed while table quoting remained.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Wouter Wolters uploaded patch set 1 10/11/26, 17:12

  2. Wouter Wolters rebased onto patch set 2 10/13/26, 17:28

  3. Wouter Wolters wrote 10/13/26, 17:28

    Unset private
  4. core-ci voted on patch set 2 V +1 10/13/26, 17:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111017

  5. Oliver Klee voted on patch set 2 CR +1 V +1 10/14/26, 10:04

  6. Benni Mack voted on patch set 2 CR +2 V +2 10/14/26, 11:18

  7. Benni Mack merged patch set 3 10/14/26, 11:18