Review main Merged

96616[TASK] Cover HMAC secret dependence in unit tests

Wouter Wolters CR +2 V +2 Easy +36 −0 updated 10/15/26, 07:49

Commit message

Assert fixed HMAC digests with nonempty installation and additional
secrets. Verify that changing the message or either secret causes
validation to reject a previously valid digest.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Wouter Wolters uploaded patch set 1 10/11/26, 17:21

  2. Wouter Wolters updated the commit message in patch set 2 10/14/26, 12:47

  3. Wouter Wolters marked it ready for review 10/14/26, 12:47

  4. Wouter Wolters wrote 10/14/26, 12:47

    Unset private
  5. core-ci voted on patch set 2 V +1 10/14/26, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111096

  6. Garvin Hicking voted on patch set 2 CR +2 V +2 10/15/26, 07:49

  7. Garvin Hicking merged patch set 3 10/15/26, 07:49