Review main Merged

96617[TASK] Isolate core updater environment flag tests

Wouter Wolters CR +2 V +2 Normal +31 −25 updated 10/16/26, 17:53

Commit message

Set Composer mode explicitly when testing the core updater flags and
cover Composer mode with both flags absent. Restore Environment and
environment variables after each test instead of relying on the
runner's installation mode.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Wouter Wolters uploaded patch set 1 10/11/26, 17:27

  2. Wouter Wolters uploaded patch set 2 10/15/26, 18:35

  3. Wouter Wolters updated the commit message in patch set 3 10/15/26, 18:35

  4. Wouter Wolters marked it ready for review 10/15/26, 18:35

  5. Wouter Wolters wrote 10/15/26, 18:35

    Unset private
  6. core-ci voted on patch set 2 V +1 10/15/26, 18:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111258

  7. core-ci voted on patch set 3 V +1 10/15/26, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111259

  8. Oliver Klee voted on patch set 3 CR +1 V +1 10/15/26, 19:35

  9. Georg Ringer voted on patch set 3 CR +2 V +2 10/16/26, 17:52

  10. Georg Ringer merged patch set 4 10/16/26, 17:53