Review main Merged

96624[TASK] Cover inclusive date query boundaries

Wouter Wolters CR +2 V +2 Easy +27 −5 updated 10/15/26, 20:48

Commit message

Exercise matching and nonmatching timestamps on either side of the
stored date for greaterThanOrEqual and lessThanOrEqual. Keep the equal
boundary checks across mutable and immutable date objects and all three
column representations so inclusive operators cannot become equality.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1113

  1. Wouter Wolters uploaded patch set 1 10/11/26, 18:15

  2. Wouter Wolters updated the commit message in patch set 2 10/14/26, 16:40

  3. Wouter Wolters marked it ready for review 10/14/26, 16:40

  4. Wouter Wolters wrote 10/14/26, 16:41

    Unset private
  5. core-ci voted on patch set 2 V +1 10/14/26, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111129

  6. Wolfgang Klinger voted on patch set 2 CR +1 V +1 10/14/26, 16:57

  7. Oliver Klee commented on patch set 2 10/14/26, 17:26

    QueryParserTest.php:230

    Can we be a bit tighter here and use `assertInstanceOf` checks instead of the `assertNotNull` checks?
  8. Wouter Wolters uploaded patch set 3 CR +1 V +1 10/15/26, 18:19

  9. Wouter Wolters commented on patch set 3 10/15/26, 18:20

    QueryParserTest.php:230 Reply

    Done
  10. core-ci voted on patch set 3 V +1 10/15/26, 18:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111256

  11. Oliver Klee voted on patch set 3 CR +1 V +1 10/15/26, 19:36

  12. Benni Mack voted on patch set 3 CR +2 V +2 10/15/26, 20:48

  13. Benni Mack merged patch set 4 10/15/26, 20:48