Review main Merged

96631[BUGFIX] Compare image extensions case-insensitively in resize()

Alexander Schnitzler CR +2 V +2 Easy +36 −2 updated 10/12/26, 18:25

Commit message

GraphicalFunctions::resize() compared the source file extension
case-sensitively against the lowercased target extension. Images
with an uppercase extension such as "photo.PNG" therefore never hit
the "nothing to do" shortcut and were processed into an identical
copy. With the target extension "web" they were also not recognised
as web images and got converted via the fallback.

The original extension is now lowercased before any comparison.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 89

  1. Alexander Schnitzler uploaded patch set 1 10/12/26, 12:17

  2. core-ci voted on patch set 1 V +1 10/12/26, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110902

  3. Alexander Schnitzler commented on patch set 1 10/12/26, 15:00

    This change is ready for review.
  4. Wouter Wolters voted on patch set 1 CR +1 10/12/26, 15:30

  5. Oliver Klee voted on patch set 1 CR +1 V +1 10/12/26, 17:29

  6. Wouter Wolters voted on patch set 1 V +1 10/12/26, 17:30

  7. Andreas Kienast voted on patch set 1 CR +1 10/12/26, 18:07

  8. Benni Mack voted on patch set 1 CR +2 V +2 10/12/26, 18:25

  9. Benni Mack merged patch set 2 10/12/26, 18:25