Review 14.3 Merged

96632[SECURITY] Respect saveToFileMount of form uploads

Elias Häußler CR +2 V +2 Hard +222 −226 updated 10/13/26, 09:15

Commit message

The upload folder of a FileUpload element was resolved in
initializeFormElement(), which runs before the element's own
properties are applied. Only the prototype default was taken
into account, so saveToFileMount set per form or element was
ignored.

The folder is now resolved at runtime in
PropertyMappingConfiguration, where the properties of the form
definition are available.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 4

Review log 1112

  1. Elias Häußler uploaded patch set 1 10/12/26, 14:05

  2. Elias Häußler uploaded patch set 2 10/12/26, 14:14

  3. Josua Vogel voted on patch set 2 CR +1 V +1 10/12/26, 14:28

  4. Elias Häußler wrote 10/13/26, 05:39

    Topic set to security
  5. Elias Häußler rebased onto patch set 3 CR +1 V +1 10/13/26, 09:04

  6. Benni Mack marked it work in progress 10/13/26, 09:11

  7. Benni Mack marked it ready for review 10/13/26, 09:11

  8. Benni Mack wrote 10/13/26, 09:11

    Unset private
  9. core-ci voted on patch set 3 V +1 10/13/26, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110993

  10. Benni Mack voted on patch set 3 CR +2 V +2 10/13/26, 09:14

  11. Benni Mack merged patch set 4 10/13/26, 09:14

  12. Elias Häußler voted on patch set 3 CR +1 V +1 10/13/26, 09:15