Review 13.4 Merged

96635[BUGFIX] Compare image extensions case-insensitively in resize()

Benni Mack CR +2 V +2 Easy +36 −2 updated 10/12/26, 19:21

Commit message

GraphicalFunctions::resize() compared the source file extension
case-sensitively against the lowercased target extension. Images
with an uppercase extension such as "photo.PNG" therefore never hit
the "nothing to do" shortcut and were processed into an identical
copy. With the target extension "web" they were also not recognised
as web images and got converted via the fallback.

The original extension is now lowercased before any comparison.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Benni Mack commented on patch set 1 10/12/26, 18:24

    Cherry Picked from branch 14.3.
  2. core-ci voted on patch set 1 V -1 10/12/26, 18:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110917

  3. Benni Mack commented on patch set 2 V -1 10/12/26, 19:13

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 10/12/26, 19:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110925

  5. Benni Mack voted on patch set 2 CR +2 V +2 10/12/26, 19:21

  6. Benni Mack merged patch set 3 10/12/26, 19:21