Review main Merged

96645[TASK] Optimize array path validation

Wouter Wolters CR +2 V +2 Normal +74 −6 updated 10/24/26, 09:15

Commit message

Check array paths directly instead of throwing and catching an
exception when a segment is missing. Site settings composition checks
known definition keys for every set and site, so missing paths add
avoidable overhead during cold settings initialization.

Preserve null values, quoted segments, empty-path exceptions and
subclass overrides of getValueByPath(). Extend the unit coverage for
these cases.

A synthetic cold settings benchmark with flat notation, 50 sites, ten
sets per site and 100 definitions per set reduces composition from 214
ms to 88 ms on PHP 8.5 with OPcache enabled. The benchmark excludes
file loading and cache writes.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Wouter Wolters uploaded patch set 1 10/12/26, 20:59

  2. Wouter Wolters wrote 10/13/26, 17:50

    Unset private
  3. Wouter Wolters updated the commit message in patch set 2 10/15/26, 16:02

  4. Wouter Wolters marked it ready for review 10/15/26, 16:02

  5. core-ci voted on patch set 2 V +1 10/15/26, 16:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111222

  6. Oliver Klee voted on patch set 2 CR +1 V +1 10/15/26, 17:39

  7. Benni Mack voted on patch set 2 CR +2 V +2 10/24/26, 09:15

  8. Benni Mack merged patch set 3 10/24/26, 09:15