Review main Merged

9667[TASK] Clean up phpDoc comments in t3lib_TStemplate

Sebastian Michaelsen CR +2 V +2 Normal +87 −85 updated 06/03/13, 20:49

Commit message

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Files 1

Review log 12

  1. Sebastian Michaelsen commented on patch set 1 05/04/12, 17:59

    (1 inline comment)
  2. Christian Kuhn uploaded patch set 3 05/04/12, 17:59

  3. Christian Kuhn commented on patch set 3 V 0 05/04/12, 17:59

    by team member; Looks good to me, approved Rebased to master, fixed commit message. no-brainer (except the pretty obvious NULL default change in one of the last hunks). Merged.
  4. Sebastian Michaelsen uploaded patch set 2 05/04/12, 17:59

  5. Philipp Gampe commented on patch set 1 05/04/12, 17:59

    (1 inline comment)
    Is 6.0 now a definite decision? Because most commit still used 4.8.
  6. Philipp Gampe commented on patch set 1 05/04/12, 17:59

    Looks good to me, but someone else must approve
  7. Philipp Gampe commented on patch set 2 05/04/12, 17:59

    Looks good to me, but someone else must approve
  8. Mr. Jenkins commented on patch set 1 05/04/12, 17:59

  9. Mr. Jenkins commented on patch set 2 05/04/12, 17:59

  10. Mr. Jenkins commented on patch set 3 05/04/12, 17:59

  11. Wouter Wolters commented on patch set 2 05/04/12, 17:59

    Looks good to me, but someone else must approve
  12. Christian Kuhn merged patch set 3 05/04/12, 17:59