Review main Abandoned

96671[TASK] Test Extbase against DataHandler for l10n_mode exclude

Alexander Schnitzler CR 0 V -1 Hard +280 −0 updated 10/18/26, 13:13

Commit message

For fields configured as "l10n_mode" => "exclude", DataHandler writes
the value of the default language record into all its translations,
records one history entry per changed record, and gives every
translation its own copy of each child of an excluded relation,
attached to the translation. Core reads the children of a translation
from these copies.

The tests describe this behaviour for Extbase. Writes through a
translation, which DataHandler does not allow, are expected to act as
writes to the default language record.

On main, the read test passes and the write tests fail. On top of
change 95445, the value tests pass, while the read test, the history
test and the child tests fail.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 2

Review log 35

  1. Alexander Schnitzler uploaded patch set 1 10/13/26, 19:09

  2. core-ci voted on patch set 1 V -1 10/13/26, 19:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111021

  3. Alexander Schnitzler uploaded patch set 2 V -1 10/13/26, 19:19

  4. core-ci voted on patch set 2 V -1 10/13/26, 19:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111022

  5. Alexander Schnitzler abandoned the change 10/18/26, 13:13

    Abandoned in favour of change 96683 "[TASK] Test Extbase against core for l10n_mode exclude", which is merged and covers the same behaviour: values of excluded fields, history entries and the copies of children of excluded relations, each compared with the core in paired tests. Changed children of excluded inline fields follow in change 96803.