Review main Ready for review

96674[TASK] Cover cascade remove with unchanged ObjectStorage

Benni Mack CR 0 V -1 Normal +123 −0 updated 11/11/26, 16:46

Commit message

The attribute #[Cascade('remove')] deletes an object on persistence
when it has been removed from the annotated property.

Functional tests now prove that re-submitting an unchanged
ObjectStorage via property mapping, or replacing it with a storage
of equal content, does not remove any children. The behaviour is
documented on the attribute.

What happens to a child that is moved to another parent is left
open, to be settled together with the 1:1 move semantics.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/74/96674/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/74/96674/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Merge conflicts 1

Issues 1

Files 3

Review log 58

  1. Benni Mack uploaded patch set 1 10/14/26, 07:33

  2. core-ci voted on patch set 1 V +1 10/14/26, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111049

  3. Wouter Wolters voted on patch set 1 CR +1 V +1 10/14/26, 07:55

  4. Alexander Schnitzler commented on patch set 1 CR -1 10/18/26, 18:35

    Thanks for closing #78714 with tests! Tests 1 and 2 are valuable: they pin that re-submitting an unchanged ObjectStorage does not remove any children. -1 for test 3 and the docblock sentence "even if it got attached to another parent object in the meantime", though. For foreign_field relations the reference is DataHandler/FormEngine, where the foreign_field is the owning side and re-attaching a child moves the row. https://review.typo3.org/c/Packages/TYPO3.CMS/+/96722 implements exactly that for 1:1 relations (the moved child survives). Merging this as is would give 1:1 and 1:n opposite semantics and document the opposite of 96722 for all cascade relations. Suggestion: keep tests 1+2, drop test 3 and the sentence (or document the current move behaviour as a known limitation rather than a contract) until the move semantics are settled together with 96722. Minor: this adds tests and a docblock, so [TASK] rather than [DOCS]. Test 2 could use a public setPosts() on the fixture model instead of _setProperty(), which https://review.typo3.org/c/Packages/TYPO3.CMS/+/88948 removes.
  5. Benni Mack uploaded patch set 2 CR +1 V +1 11/11/26, 16:02

  6. Benni Mack updated the commit message in patch set 3 11/11/26, 16:03

  7. core-ci voted on patch set 3 V -1 11/11/26, 16:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114123

  8. core-ci voted on patch set 2 V -1 11/11/26, 16:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114122