Review main Merged

96679[BUGFIX] Do not share doc header components between module templates

Oli Bartsch CR +2 V +2 Easy +28 −5 updated 10/14/26, 20:45

Commit message

Each ModuleTemplate retrieves its DocHeaderComponent from the
container, where it, its ButtonBar and its MenuRegistry were shared
services. All module templates created in the same process therefore
wrote into the same button bar and menu registry.

A second module template within one request, as well as functional
tests dispatching a module more than once, rendered the buttons of
the previous one. Menus with different identifiers even made the
doc header throw, as it only allows a single menu.

The stateful components are now declared as non-shared services, so
every module template gets its own instances. The workaround in
RecordListControllerTest is removed accordingly.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 67

  1. Oli Bartsch uploaded patch set 1 10/14/26, 09:04

  2. core-ci voted on patch set 1 V +1 10/14/26, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111067

  3. Simon Schaufelberger voted on patch set 1 CR +1 V +1 10/14/26, 09:46

  4. Georg Ringer voted on patch set 1 CR +1 V +1 10/14/26, 12:31

  5. Wouter Wolters voted on patch set 1 CR +1 V +1 10/14/26, 15:56

  6. Oli Bartsch voted on patch set 1 CR +2 V +2 10/14/26, 20:45

  7. Oli Bartsch merged patch set 2 10/14/26, 20:45