Review main Merged

96680[TASK] Use class_attributes_separation php-cs-fixer style requirements

Simon Schaufelberger CR +2 V +2 Hard +209 −46 updated 11/20/26, 21:18

Commit message

Add an empty line around methods.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 136

Show 116 more files

Review log 1721

  1. Simon Schaufelberger uploaded patch set 1 10/14/26, 09:37

  2. Simon Schaufelberger uploaded patch set 2 10/14/26, 09:44

  3. Oliver Klee voted on patch set 2 CR +1 V +1 10/14/26, 10:02

  4. core-ci voted on patch set 2 V +1 10/14/26, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111081

  5. Garvin Hicking commented on patch set 2 10/14/26, 10:09

    FieldTypeInterface.php:27

    Could we exclude this for interfaces?
  6. Garvin Hicking commented on patch set 2 10/14/26, 10:09

    PasswordResetTest.php:153

    I think for dynamic class declarations, the newline here makes it harder to read
  7. Simon Schaufelberger commented on patch set 2 10/14/26, 10:11

    FieldTypeInterface.php:27 Reply

    I don't know how to exclude a rule for a file. I know that ECS can do that but php-cs-fixer can only exclude files for all rules, or?
  8. Garvin Hicking commented on patch set 2 10/14/26, 10:11

    NodeInterface.php:49

    (This interface here is a good example, where it makes the structurization less legible)
  9. Simon Schaufelberger commented on patch set 2 10/15/26, 10:51

    PasswordResetTest.php:153 Reply

    Acknowledged

    FieldTypeInterface.php:27 Reply

    there is no easy and nice way to exclude a file for a rule in php-cs-fixer.

    NodeInterface.php:49 Reply

    Done
  10. Simon Schaufelberger uploaded patch set 3 CR +1 V +1 10/28/26, 17:21

  11. core-ci voted on patch set 3 V +1 10/28/26, 17:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112743

  12. Oliver Klee voted on patch set 3 CR +1 V +1 10/29/26, 10:50

  13. Georg Ringer voted on patch set 3 CR +1 V +1 10/31/26, 12:32

  14. Simon Schaufelberger uploaded patch set 4 CR +1 V +1 11/03/26, 11:24

  15. core-ci voted on patch set 4 V +1 11/03/26, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113147

  16. Georg Ringer voted on patch set 4 CR +1 V +1 11/03/26, 11:47

  17. Oliver Klee voted on patch set 4 CR +1 V +1 11/03/26, 12:48

  18. Georg Ringer uploaded patch set 5 CR +1 V +1 11/20/26, 20:59

  19. core-ci voted on patch set 5 V +1 11/20/26, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115092

  20. Georg Ringer voted on patch set 5 CR +2 V +2 11/20/26, 21:18

  21. Georg Ringer merged patch set 6 11/20/26, 21:18