Review main Merged

96686[BUGFIX] Return a failure exit code from fluid:analyze --json

Lina Wolf CR +2 V +2 Normal +63 −4 updated 10/15/26, 09:32

Commit message

With --json, fluid:analyze printed the errors of invalid templates
but always returned exit code 0. Without --json, the command returns
exit code 1 if a template has errors. A CI step that used --json
could not fail on template errors.

Return exit code 1 with --json as well if a template has errors.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 45

  1. Lina Wolf uploaded patch set 1 10/14/26, 15:06

  2. core-ci voted on patch set 1 V +1 10/14/26, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111118

  3. Wouter Wolters voted on patch set 1 CR +1 V +1 10/14/26, 15:47

  4. Garvin Hicking voted on patch set 1 CR +2 V +2 10/15/26, 08:07

  5. Garvin Hicking merged patch set 2 10/15/26, 09:32