Review main Ready for review Quiet

96696[BUGFIX] Keep copies of monoglot inline children per translation

Alexander Schnitzler CR -1 V +1 Hard +263 −4 updated 10/30/26, 21:52

Commit message

An inline child without language configuration ("monoglot") is copied
into every translation of its parent when the inline field is
synchronized, e.g. by "l10n_mode" => "exclude". With two or more
translations the copies are mixed up: DataMapProcessor finds the copy
of a child by its origin only, regardless of language and parent, so
one translation takes over the copies of another one.

Only copies attached to the translation being synchronized are
considered now.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/96/96696/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/96/96696/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR -1 Needs a vote
    • Oliver Klee +1
    • Benni Mack -1
  • Verified V +1 Needs a vote
    • Oliver Klee +1
    • core-ci +1 CI

Merge conflicts 4

Issues 1

Files 8

Review log 68

  1. Alexander Schnitzler uploaded patch set 1 10/14/26, 18:18

  2. core-ci voted on patch set 1 V -1 10/14/26, 18:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111140

  3. Alexander Schnitzler uploaded patch set 2 V -1 10/14/26, 19:20

  4. core-ci voted on patch set 2 V +1 10/14/26, 19:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111144

  5. Alexander Schnitzler commented on patch set 2 10/14/26, 19:36

    This change is ready for review.
  6. Oliver Klee voted on patch set 2 CR +1 V +1 10/15/26, 13:44

  7. Alexander Schnitzler wrote 10/17/26, 19:48

    Topic set to DataHandler
  8. Benni Mack commented on patch set 2 CR -1 10/30/26, 21:52

    Unresolved

    There is another issue with this change, which I need to find the right issue to it.