Review main Merged

96705[TASK] Report redirects shadowed by another redirect

Oli Bartsch CR +2 V +2 Hard +270 −0 updated 10/16/26, 15:38

Commit message

The redirects module allows to store multiple redirects with the
same source. Only the first active one is ever matched, all others
are silently ignored, which is not visible to editors.

The redirects:checkintegrity command now marks redirects with the
new integrity status "shadowed", if another enabled redirect is
matched first for every request and at any time the redirect
itself would be active. Source host, normalized source path,
regular expression and query parameter handling as well as start
and end time are taken into account.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Guido Schmechel +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 56

  1. Oli Bartsch uploaded patch set 1 10/15/26, 07:17

  2. core-ci voted on patch set 1 V +1 10/15/26, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111166

  3. Guido Schmechel commented on patch set 1 CR +1 V +1 10/16/26, 10:28

    Thanks for implementing this. An initial test within the Redirect module worked perfectly. The issue that was noted back then regarding short URLs also applies here: If there is a short URL named “test” and also a redirect named “test,” there is no warning. However, the context is probably different now. For the original ticket, this implementation is appropriate. Thank you! :-)
  4. Georg Ringer voted on patch set 1 CR +1 V +1 10/16/26, 13:50

  5. Oli Bartsch voted on patch set 1 CR +2 V +2 10/16/26, 15:38

  6. Oli Bartsch merged patch set 2 10/16/26, 15:38