96706[TASK] Warn when saving a shadowed redirect
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 3
Files 6
- typo3/sysext/redirects/Classes/Hooks/DataHandlerShadowedRedirectHook.php3new+122 −0
- typo3/sysext/redirects/Classes/Service/IntegrityService.php+45 −5
- typo3/sysext/redirects/Resources/Private/Language/locallang_module_redirect.xlf+6 −0
- typo3/sysext/redirects/Tests/Functional/Hooks/Fixtures/ShadowedRedirects/sys_redirect.csvnew+6 −0
- typo3/sysext/redirects/Tests/Functional/Hooks/DataHandlerShadowedRedirectHookTest.phpnew+151 −0
- typo3/sysext/redirects/ext_localconf.php+3 −0
Review log 1215
-
Oli Bartsch uploaded patch set 1 10/15/26, 07:27
-
core-ci voted on patch set 1 V +1 10/15/26, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111167
-
Oli Bartsch rebased onto patch set 2
V +110/16/26, 15:39 -
core-ci voted on patch set 2 V +1 10/16/26, 15:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111377
-
Oliver Klee voted on patch set 2 V +1 10/17/26, 17:09
-
Oli Bartsch wrote 10/19/26, 07:19
Topic set to community-sprint -
Guido Schmechel commented on patch set 2 10/19/26, 12:23
DataHandlerShadowedRedirectHook.php:109Just to make sure I understand: Is there a reason why the RedirectRepository isn't being used here? Is it because this function only used in one place? The feature is pretty general, so maybe it would make sense there? -
Garvin Hicking commented on patch set 2 10/19/26, 14:47
Important-111073-SavingAShadowedRedirectShowsAWarning.rst:3I don't think we need this RST -
Oli Bartsch uploaded patch set 3
V +110/19/26, 16:17 -
Oli Bartsch commented on patch set 3 10/19/26, 16:17
Important-111073-SavingAShadowedRedirectShowsAWarning.rst:3ReplyDoneDataHandlerShadowedRedirectHook.php:109ReplyThe lookup intentionally runs without any restrictions: after a delete command the record is already deleted=1, and hidden/timed redirects take part in shadowing as well. RedirectRepository is tailored to the backend module, so an unrestricted method there would be the odd one out and easy to misuse in a permission-relevant context. -
core-ci voted on patch set 3 V +1 10/19/26, 16:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111675
-
Guido Schmechel commented on patch set 3 10/19/26, 20:02
DataHandlerShadowedRedirectHook.php:109ReplyOkay, I understand. Thanks for the explanation :-) -
Garvin Hicking voted on patch set 3 CR +1 V +1 10/19/26, 21:03
-
Oli Bartsch voted on patch set 3 CR +2 V +2 10/22/26, 20:00
-
Oli Bartsch merged patch set 4 10/22/26, 20:00