Review main Abandoned

9671[BUGFIX] CF FileBackend unlimited liftime support

Dominique Feyer CR 0 V 0 Easy +21 −2 updated 09/26/13, 15:49

Commit message

This patch fix the bug, based on the DB backend implementation

Review

  • Code review CR 0
  • Verified V 0

Files 2

Review log 20

  1. Sebastian Michaelsen commented on patch set 1 05/27/13, 17:19

    (2 inline comments)
    Would you mind adding the target releases?

    class.t3lib_cache_backend_filebackend.php:48

    superfluous closing parens
  2. Dominique Feyer uploaded patch set 2 05/27/13, 17:19

    class.t3lib_cache_backend_filebackend.php:291 Reply

    Yes in the case 1 (is_null === TRUE) we need to add the EXEC_TIME. This code come from the DB backend. So if we change something we need to check the other backend too
  3. Philipp Gampe commented on patch set 3 05/27/13, 17:19

    I would prefer that you didn't submit this Please the commit message guidelines. The commit message should be in present tense and describe what the commit does. "This patch fixes the bug" is not a good commit message. I will try to come up with a better on once I get home.

    class.t3lib_cache_backend_filebackend.php:291

    any reason not to just set the $expiryTime to $self::FAKED_UNLIMITED_EXPIRE? Because you subtract exec_time from FAKED_UNLIMITED_EXPIRE and then you add it back again. That seems not to make much sense to me.
  4. Christian Kuhn commented on patch set 4 05/27/13, 17:19

    Will take a look, probably this weekend.
  5. Philipp Gampe commented on patch set 4 05/27/13, 17:19

    (1 inline comment) Ok here is the reworked commit message. I have a more conceptual question, see inline comment. Also I think this is more a feature than a bugfix?! Or are backends supposed to have support for unlimited lifetime?
  6. Philipp Gampe commented on patch set 4 2 comments 05/27/13, 17:19

    Looks good to me, but someone else must approve
  7. Philipp Gampe uploaded patch set 4 05/27/13, 17:19

  8. Dominique Feyer uploaded patch set 3 05/27/13, 17:19

  9. Dominique Feyer commented on patch set 4 05/27/13, 17:19

    (1 inline comment) No it's a bugfix, if you check t3lib_cache_frontend_Frontend: * @param integer $lifetime Lifetime of this cache entry in seconds. If NULL is specified, the default lifetime is used. "0" means unlimited liftime. So it's a unlimeted liftime must be supported by all backend.
  10. Philipp Gampe commented on patch set 5 05/27/13, 17:19

    Looks good to me, but someone else must approve @Christian wanna take a look?
  11. Philipp Gampe commented on patch set 5 05/27/13, 17:19

    Fails needs a rebase
  12. Dominique Feyer commented on patch set 5 05/27/13, 17:19

    Just add 6.0 in the commit message
  13. Dominique Feyer uploaded patch set 5 05/27/13, 17:19

  14. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  15. Mr. Jenkins commented on patch set 3 05/27/13, 17:19

  16. Mr. Jenkins commented on patch set 4 05/27/13, 17:19

  17. Mr. Jenkins commented on patch set 5 05/27/13, 17:19

  18. Christian Kuhn commented on patch set 5 09/26/13, 15:15

    working on this one again.
  19. Christian Kuhn commented on patch set 5 09/26/13, 15:33

    class.t3lib_cache_backend_filebackend.php:291

    this was fixed since 6.0 with this code: $lifetime = $lifetime === NULL ? $this->defaultLifetime : $lifetime; $expiryTime = ($lifetime === 0) ? 0 : ($GLOBALS['EXEC_TIME'] + $lifetime);
  20. Christian Kuhn abandoned the change 09/26/13, 15:49

    abandoned on master, new 4.7 version is pending with https://review.typo3.org/#/c/24073/