Review 14.3 Abandoned

96713[BUGFIX] Revert "[TASK] Identify remote packages by key, version and remote"

Garvin Hicking CR 0 V 0 Normal +105 −19 updated 10/15/26, 08:20

Commit message

This reverts commit 44a7e722b21a9056962a4b1f869da9b3b67f65ad.

Reason for revert:

Local extensions can not be installed via extension manager in
classic mode, when they have not been released to TER.
They are unconditionally tried to be downloaded, because
`ExtensionService` checks if the `remote` property is a non empty
string, while it is always provided with a `'ter'` fallback in
the `createFromExtensionArray()` factory.

This means:

 * If an extension is not released to TER, it can not be installed
 * If an extension is released to TER, it is forcefully downloaded
   from TER and any local change is discarded
   (the extension is replaced with what is downloaded from TER)

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 11

Review log 3

  1. Garvin Hicking commented on patch set 1 10/15/26, 08:20

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/extensionmanager/Classes/Controller/DistributionController.php * typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php * typo3/sysext/extensionmanager/Classes/Domain/Model/Extension.php * typo3/sysext/extensionmanager/Classes/Domain/Model/PackageIdentifier.php * typo3/sysext/extensionmanager/Classes/Domain/Repository/ExtensionRepository.php * typo3/sysext/extensionmanager/Classes/ViewHelpers/DownloadExtensionViewHelper.php * typo3/sysext/extensionmanager/Resources/Private/Partials/List/Distribution.fluid.html * typo3/sysext/extensionmanager/Resources/Private/Templates/Distribution/Show.fluid.html * typo3/sysext/extensionmanager/Resources/Private/Templates/Download/InstallFromTer.fluid.json * typo3/sysext/extensionmanager/Tests/Unit/Domain/Model/PackageIdentifierTest.php
  2. Garvin Hicking wrote 10/15/26, 08:20

    Topic set to #no-backport
  3. Garvin Hicking abandoned the change 10/15/26, 08:20

    won't do even though listed in Releases: