96715[TASK] Add a disabled state to generic and pseudo buttons
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- core-ci +1 CI
Issues 1
Files 8
- Build/Sources/TypeScript/backend/element/pseudo-button.ts+29 −5
- Build/Sources/TypeScript/backend/element/sidebar-toggle-element.ts+1 −15
- Build/Sources/TypeScript/backend/tests/element/pseudo-button-test.tsnew+95 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/GenericButton.php2+19 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/LinkButton.php+1 −0
- typo3/sysext/backend/Resources/Public/JavaScript/element/pseudo-button.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/element/sidebar-toggle-element.js+1 −1
- typo3/sysext/backend/Tests/Unit/Template/Components/Button/GenericButtonTest.php+15 −0
Review log 1216
-
Benjamin Kott uploaded patch set 1 10/15/26, 11:46
-
core-ci voted on patch set 1 V +1 10/15/26, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111184
-
Benjamin Franzke uploaded patch set 2
V +110/15/26, 13:26 -
Benjamin Franzke voted on patch set 2 CR +1 V +1 10/15/26, 13:27
-
Benjamin Franzke uploaded patch set 3
CR +1V +110/15/26, 13:39 -
core-ci voted on patch set 2 V -1 10/15/26, 13:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111191
-
Benjamin Franzke voted on patch set 3 CR +1 V +1 10/15/26, 13:42
-
core-ci voted on patch set 3 V +1 10/15/26, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111196
-
Benni Mack voted on patch set 3 CR +1 V +1 10/15/26, 14:00
-
Benjamin Kott voted on patch set 3 CR +2 V +2 10/15/26, 14:13
-
Benjamin Kott updated the commit message in patch set 4
CR +1V +110/15/26, 14:43 -
Benjamin Franzke voted on patch set 4 CR +1 V +1 10/15/26, 14:45
-
Benjamin Kott voted on patch set 4 CR +2 V +2 10/15/26, 14:45
-
core-ci voted on patch set 4 V +1 10/15/26, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111212
-
Benjamin Kott merged patch set 5 10/15/26, 15:01
-
Ayke Halder commented on patch set 5 11/17/26, 15:01
GenericButton.php:215UnresolvedThe mentioned `class="disabled"` is not set anywhere.GenericButton.php:250UnresolvedThis adds a wrong attribute `disabled` for tags other than `button`. E.g. `<a href="…" disabled>…</a>` is invalid HTML code. For non-`button` elements this is totally ignored by browser and screenreaders.
Unresolved