Review main Merged

96715[TASK] Add a disabled state to generic and pseudo buttons

Benjamin Kott CR +2 V +2 Normal +162 −22 updated 11/17/26, 15:01

Commit message

GenericButton::setDisabled() renders the attribute "disabled".

The custom elements of the backend that act as a button follow that
attribute as a disabled <button> does: no activation by a click, Enter
or Space, out of the tab order, announced as disabled. The sidebar
toggle, which did this on its own, now inherits it.

Also the LinkButton is adapted to set tabindex to -1 if it is
disabled in order to ensure it is not focusable, in order to
create a uniform behavior across all button types.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1216

  1. Benjamin Kott uploaded patch set 1 10/15/26, 11:46

  2. core-ci voted on patch set 1 V +1 10/15/26, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111184

  3. Benjamin Franzke uploaded patch set 2 V +1 10/15/26, 13:26

  4. Benjamin Franzke voted on patch set 2 CR +1 V +1 10/15/26, 13:27

  5. Benjamin Franzke uploaded patch set 3 CR +1 V +1 10/15/26, 13:39

  6. core-ci voted on patch set 2 V -1 10/15/26, 13:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111191

  7. Benjamin Franzke voted on patch set 3 CR +1 V +1 10/15/26, 13:42

  8. core-ci voted on patch set 3 V +1 10/15/26, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111196

  9. Benni Mack voted on patch set 3 CR +1 V +1 10/15/26, 14:00

  10. Benjamin Kott voted on patch set 3 CR +2 V +2 10/15/26, 14:13

  11. Benjamin Kott updated the commit message in patch set 4 CR +1 V +1 10/15/26, 14:43

  12. Benjamin Franzke voted on patch set 4 CR +1 V +1 10/15/26, 14:45

  13. Benjamin Kott voted on patch set 4 CR +2 V +2 10/15/26, 14:45

  14. core-ci voted on patch set 4 V +1 10/15/26, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111212

  15. Benjamin Kott merged patch set 5 10/15/26, 15:01

  16. Ayke Halder commented on patch set 5 11/17/26, 15:01

    Unresolved

    Post -1: 3 h 15 min to review … was this on a sprint?

    GenericButton.php:215 Unresolved

    The mentioned `class="disabled"` is not set anywhere.

    GenericButton.php:250 Unresolved

    This adds a wrong attribute `disabled` for tags other than `button`. E.g. `<a href="…" disabled>…</a>` is invalid HTML code. For non-`button` elements this is totally ignored by browser and screenreaders.