Review main Merged

96716[TASK] Show the QR code button disabled without a URL

Benjamin Kott CR +2 V +2 Easy +21 −1 updated 10/15/26, 15:13

Commit message

ComponentFactory::createQrCodeButton() renders the button disabled for
an empty URL, as createViewButton() does without preview attributes.
A module can then show both buttons the same way where a page has no
frontend URL, instead of a QR code button with nothing to encode.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 710

  1. Benjamin Kott uploaded patch set 1 10/15/26, 11:46

  2. core-ci voted on patch set 1 V +1 10/15/26, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111185

  3. Benjamin Franzke rebased onto patch set 2 V +1 10/15/26, 13:26

  4. Benjamin Franzke voted on patch set 2 CR +1 V +1 10/15/26, 13:27

  5. Benjamin Franzke rebased onto patch set 3 CR +1 V +1 10/15/26, 13:39

  6. core-ci voted on patch set 2 V -1 10/15/26, 13:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111192

  7. Benjamin Franzke voted on patch set 3 CR +1 V +1 10/15/26, 13:42

  8. core-ci voted on patch set 3 V +1 10/15/26, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111197

  9. Benjamin Kott voted on patch set 3 CR +2 V +2 10/15/26, 14:14

  10. Benjamin Kott merged patch set 4 10/15/26, 15:13