Review main Ready for review

96726[BUGFIX] Hide broken links of records hidden after the check

Benni Mack CR -1 V +1 Normal +103 −3 updated 11/10/26, 15:19

Commit message

With "mod.linkvalidator.checkhidden = 0" hidden records are skipped
when links are checked, but broken links stored before a record got
hidden were still listed in the report until the next check.

getAllBrokenLinksForPages() now accepts a "considerHidden" flag.
When it is disabled, broken links of records which are no longer
visible - using the same restrictions as the link analyzer - are
omitted. The backend module and the scheduler task pass the
"checkhidden" setting.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/26/96726/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/26/96726/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR -1 Needs a vote
    • Wouter Wolters +1
    • Josua Vogel -1
    • Simon Schaufelberger +1
  • Verified V +1 Needs a vote
    • Wouter Wolters +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Merge conflicts 1

Issues 1

Files 4

Review log 45

  1. Benni Mack uploaded patch set 1 10/15/26, 14:17

  2. core-ci voted on patch set 1 V +1 10/15/26, 14:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111205

  3. Wouter Wolters voted on patch set 1 CR +1 V +1 10/15/26, 19:00

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 11/06/26, 09:25

  5. Josua Vogel commented on patch set 1 CR -1 11/10/26, 15:19

    BrokenLinkRepository.php:244 Unresolved

    this would be breaking if someone extended BrokenLinkRepository