96732[BUGFIX] Follow redirects of page content error pages
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 2
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/32/96732/2 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/32/96732/2 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 1
Issues 1
Files 5
- typo3/sysext/core/Classes/Error/PageErrorHandler/PageContentErrorHandler.php2+38 −0
- typo3/sysext/core/Tests/Functional/Error/PageErrorHandler/Fixtures/PageContentErrorHandlerUserFuncs.php+10 −0
- typo3/sysext/core/Tests/Functional/Error/PageErrorHandler/Fixtures/pages.csv+9 −5
- typo3/sysext/core/Tests/Functional/Error/PageErrorHandler/Fixtures/PageWithPropagatedNotFoundResponse.typoscript+18 −0
- typo3/sysext/core/Tests/Functional/Error/PageErrorHandler/PageContentErrorHandlerTest.php+57 −0
Review log 57
-
Benni Mack uploaded patch set 1 10/15/26, 16:55
-
Wouter Wolters voted on patch set 1 CR +1 V +1 10/15/26, 17:07
-
core-ci voted on patch set 1 V +1 10/15/26, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111244
-
Oli Bartsch commented on patch set 1 10/29/26, 22:21
the issue reports a custom middleware answering the error page URL with a 307, and that case still throws 1544172839 with this patch. The same goes for mount points with `mount_pid_ol`, link pages to external URLs and EXT:redirects records.PageContentErrorHandler.php:136the shortcut is resolved with the main request's language, but `resolveUrl()` picks the error page language later. Since `pages.shortcut` and `doktype` are translatable, a translated shortcut can lead to the wrong target or still produce the 307. We could determine the language first and use `PageRepository::withLanguageAspect()`. WDYT? -
Benni Mack uploaded patch set 2
CR +1V +110/30/26, 16:45 -
core-ci voted on patch set 2 V +1 10/30/26, 16:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112893
-
Benni Mack commented on patch set 2 10/30/26, 21:32
Reply
now fixed.PageContentErrorHandler.php:136ReplyI took a different approach now, which adapts to the process of the one in the ticket (not just shortcuts).