Review main Merged

96737[BUGFIX] Rewrite relative URLs in inline CSS of f:asset.css

Georg Ringer CR +2 V +2 Normal +92 −0 updated 10/19/26, 20:55

Commit message

The ViewHelper `f:asset.css` with `inline="1"` embedded the stylesheet
as is, so relative `url()` and `@import` paths pointed to non-existing
locations in the HTML document. `page.includeCSS` with `inline = 1`
already rewrites them.

The ViewHelper now uses the same RelativeCssPathFixer. References to
files that do not exist now throw an exception, as with TypoScript.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josua Vogel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josua Vogel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 78

  1. Georg Ringer uploaded patch set 1 10/15/26, 19:52

  2. Georg Ringer commented on patch set 1 10/15/26, 19:52

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/15/26, 19:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111262

  4. Benni Mack voted on patch set 1 CR +1 V +1 10/15/26, 20:03

  5. Josua Vogel voted on patch set 1 CR +1 V +1 10/15/26, 20:53

  6. Simon Schaufelberger voted on patch set 1 CR +1 V +1 10/19/26, 14:59

  7. Benni Mack voted on patch set 1 CR +2 V +2 10/19/26, 20:55

  8. Benni Mack merged patch set 2 10/19/26, 20:55