Review main Ready for review Quiet

96743[BUGFIX] Inject widget configuration only if constructor accepts it

Benni Mack CR 0 V 0 Normal +115 −1 updated 10/15/26, 22:29

Commit message

Widgets implementing WidgetRendererInterface receive their
configuration via WidgetContext and therefore do not need to declare
a "$configuration" constructor argument anymore. DashboardWidgetPass
nevertheless always set this named argument, which made the container
compilation fail for such widgets.

The argument is now only injected when the constructor of the widget
class declares it. Definitions without a class or with a factory keep
the previous behaviour.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/43/96743/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/43/96743/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Issues 1

Files 4

Review log 23

  1. Benni Mack uploaded patch set 1 10/15/26, 22:10

  2. core-ci voted on patch set 1 V +1 10/15/26, 22:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111288

  3. Benni Mack marked it ready for review 10/15/26, 22:29