Review main Abandoned

96753[TASK] Introduce typed image effect value objects

Benni Mack CR 0 V 0 Expert +1260 −60 updated 10/17/26, 12:30

Commit message

Each EFFECT keyword becomes a readonly value object that reads its
own TypoScript value and normalizes it, so the bounds of an effect
are defined and tested in one place instead of inside GifBuilder.

EffectParser maps the keywords to these classes, GdEffectRenderer
applies them to a GraphicsCanvas. The renderer declares the effects
it supports, and GifBuilder skips any effect it cannot render, so
which backend renders which effect is explicit and can be inspected,
which a list of closures would not allow. All classes stay @internal.

blur and sharpen now stop at 99 as documented. rotate takes any
angle and normalizes it to one turn, which v14 clamped to 0..360.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 25

Show 5 more files

Review log 23

  1. Benni Mack uploaded patch set 1 10/16/26, 12:04

  2. core-ci voted on patch set 1 V +1 10/16/26, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111356

  3. Benni Mack abandoned the change 10/17/26, 12:30

    wont do