Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
96765[WIP][TASK] Use HTML form element based selector in Typescript
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 3
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/65/96765/3 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/65/96765/3 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Issues 2
Files 30
- Build/Sources/TypeScript/backend/form-engine/container/inline-control-container.ts+25 −25
- Build/Sources/TypeScript/backend/form-engine/element/extra/item-count.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine/element/slug-element.ts+6 −5
- Build/Sources/TypeScript/backend/form-engine/field-control/link-popup.ts+2 −2
- Build/Sources/TypeScript/backend/form-engine/field-control/reset-selection.ts+2 −1
- Build/Sources/TypeScript/backend/form-engine-validation.ts+8 −8
- Build/Sources/TypeScript/backend/form-engine.ts1+6 −6
- Build/Sources/TypeScript/backend/global-event-handler.ts1+5 −3
- Build/Sources/TypeScript/backend/link-browser.ts+2 −1
- Build/Sources/TypeScript/backend/mail-link-handler.ts+3 −2
- Build/Sources/TypeScript/backend/telephone-link-handler.ts+2 −1
- Build/Sources/TypeScript/backend/url-link-handler.ts+3 −2
- Build/Sources/TypeScript/lowlevel/query-generator.ts+2 −1
- Build/Sources/TypeScript/scheduler/scheduler-add-group.ts+2 −1
- Build/eslint.config.mjs+1 −0
- Build/tsconfig.json+1 −0
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/inline-control-container.js+6 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/extra/item-count.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/slug-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/field-control/link-popup.js+1 −1
Show 10 more files
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/field-control/reset-selection.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-validation.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/global-event-handler.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/link-browser.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/mail-link-handler.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/telephone-link-handler.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/url-link-handler.js+1 −1
- typo3/sysext/lowlevel/Resources/Public/JavaScript/query-generator.js+1 −1
- typo3/sysext/scheduler/Resources/Public/JavaScript/scheduler-add-group.js+1 −1
Review log 47
-
Ayke Halder uploaded patch set 1 10/16/26, 16:20
-
Ayke Halder commented on patch set 1 10/16/26, 16:32
global-event-handler.ts:141Unresolved@ben@bnf.dev This is a general solution to your comment here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86724/comments/fb37bc5e_57f8c2bd > Example in Build/Sources/TypeScript/backend/global-event-handler.ts: The patch replaces `instanceof HTMLElement` with a generic type declaration to HTMLElement (which isn't actually guaranteed!) and thus makes our codebase less robust. `querySelector*` can also return SVGElements for generic selectors, therefore we need to be very cautious to not introduce makes the code less robust. ---- A more specific solution would be to list the actual possible HTML element tags. E.g. ``` selector`:is(input, textarea, select)[name=${CSS.escape(name)}]` . ``` -
Ayke Halder uploaded patch set 2 10/16/26, 16:36
-
core-ci voted on patch set 1 V -1 10/16/26, 16:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111381
-
Ayke Halder updated the commit message in patch set 3 10/16/26, 16:40
-
core-ci voted on patch set 2 V -1 10/16/26, 16:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111383
-
core-ci voted on patch set 3 V -1 10/16/26, 16:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111384
form-engine.ts:101Unresolved