Review main Merged

96766[BUGFIX] Keep creation date when moving or renaming a file

Georg Ringer CR +2 V +2 Normal +117 −3 updated 11/19/26, 09:56

Commit message

Moving or renaming a file in the file list no longer changes
sys_file.creation_date. The file system changes the ctime on both
operations, which the indexer stored as creation date.

Indexer->updateIndexEntry() has a new optional argument to keep an
existing creation date. ResourceStorage uses it when moving and
renaming a file. Replacing a file or changing its contents still
update the creation date.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1113

  1. Georg Ringer uploaded patch set 1 10/16/26, 17:12

  2. Georg Ringer commented on patch set 1 10/16/26, 17:13

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/16/26, 17:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111386

  4. Markus Klein commented on patch set 1 10/16/26, 19:52

    Actually not sure how to deal with this. changing the creation date when content is modified? does not seem right. But depending on the underlying driver the ctime might change if we move between drivers? (local to remote)
  5. Benni Mack commented on patch set 1 10/31/26, 20:03

  6. Georg Ringer uploaded patch set 2 V +1 11/03/26, 19:36

  7. Georg Ringer commented on patch set 2 11/03/26, 19:37

    Reply

    Replacing or changing a file's content still updates the creation date as before; this patch only covers move and rename, so that would be a separate issue. Moving between storages is covered by a new test in patch set 2 (it fails without the change): the stored creation date is kept, the target driver's ctime is not used.
  8. core-ci voted on patch set 2 V +1 11/03/26, 19:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113212

  9. Benni Mack voted on patch set 2 CR +1 V +1 11/04/26, 08:31

  10. Markus Klein voted on patch set 2 CR +1 V +1 11/04/26, 11:38

  11. Simon Schaufelberger voted on patch set 2 CR +1 V +1 11/06/26, 00:53

  12. Benni Mack voted on patch set 2 CR +2 V +2 11/19/26, 09:56

  13. Benni Mack merged patch set 3 11/19/26, 09:56