Review main Ready for review Quiet

96769[BUGFIX] Remove closing tag of tags dropped by rmTagIfNoAttrib

Georg Ringer CR 0 V 0 Easy +32 −0 updated 10/16/26, 19:04

Commit message

HtmlParser now remembers opening tags which are removed due to
rmTagIfNoAttrib and drops their matching closing tag as well.
Closing tags are no longer paired with the opening tag of an
enclosing element of the same name, so nested tags like
<span class="big">a<span class="shy">-</span>b</span> keep their
outer element intact.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/69/96769/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/69/96769/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Georg Ringer uploaded patch set 1 10/16/26, 18:32

  2. Georg Ringer commented on patch set 1 CR +1 V +1 10/16/26, 18:33

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/16/26, 18:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111392

  4. Georg Ringer voted on patch set 1 CR 0 V 0 10/16/26, 19:04