Review main Merged

96779[FEATURE] Allow stdWrap for config.headerComment

Georg Ringer CR +2 V +2 Normal +111 −1 updated 10/19/26, 19:29

Commit message

The TypoScript property config.headerComment is now evaluated
with stdWrap in the context of the current page record before it
is added to the generated HTML source. Integrators can build the
comment dynamically, for example with insertData, data, wrap or
if.

Escape HTML comment endings after stdWrap evaluation to prevent
potential XSS through editor-controlled page fields. Other
characters remain unchanged.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Eric Harrer +1
    • Matthias Vogel +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Eric Harrer +1
    • Matthias Vogel +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 811

  1. Georg Ringer uploaded patch set 1 10/17/26, 09:29

  2. Georg Ringer commented on patch set 1 10/17/26, 09:30

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/17/26, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111436

  4. Matthias Vogel uploaded patch set 2 V +1 10/17/26, 15:07

  5. Matthias Vogel voted on patch set 2 CR +1 V +1 10/17/26, 15:07

  6. core-ci voted on patch set 2 V -1 10/17/26, 15:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111469

  7. core-ci voted on patch set 2 V +1 10/17/26, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111469

  8. Eric Harrer voted on patch set 2 CR +1 V +1 10/19/26, 13:04

  9. Garvin Hicking commented on patch set 2 CR +1 V +1 10/19/26, 18:50

    Not sure I really see a use case for this (I'd argue meta tags or visibile output is the better chose). But I checked this for security and performance implication and "it's okay" for me.
  10. Garvin Hicking voted on patch set 2 CR +2 V +2 10/19/26, 19:29

  11. Garvin Hicking merged patch set 3 10/19/26, 19:29