96780[!!!][TASK] Rename GFX/processor_effects to GFX/sharpen
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benjamin Kott +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 15
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php3+15 −10
- typo3/sysext/core/Classes/Service/SilentConfigurationUpgradeService.php+9 −28
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −1
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml2+2 −2
- typo3/sysext/core/Documentation/Changelog/15.0/Breaking-111109-GFXSettingProcessorEffectsRenamedToSharpen.rstnew+60 −0
- typo3/sysext/core/Tests/Functional/Imaging/GraphicalFunctionsResizeTest.php+80 −0
- typo3/sysext/core/Tests/Functional/Service/SilentConfigurationUpgradeServiceTest.php+34 −54
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/ImageViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/ImageViewHelperTest.php+1 −1
- typo3/sysext/install/Classes/Configuration/Image/CustomPreset.php+1 −1
- typo3/sysext/install/Classes/Configuration/Image/GraphicsMagickPreset.php+1 −1
- typo3/sysext/install/Classes/Configuration/Image/ImageMagick6Preset.php+1 −1
- typo3/sysext/install/Classes/Controller/EnvironmentController.php+1 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+5 −0
- typo3/sysext/install/Resources/Private/Templates/Environment/ImageProcessing.fluid.html+2 −2
Review log 1420
-
Benjamin Kott uploaded patch set 1 10/17/26, 09:53
-
core-ci voted on patch set 1 V +1 10/17/26, 10:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111442
-
Benjamin Kott rebased onto patch set 2
V +110/17/26, 11:55 -
core-ci voted on patch set 2 V +1 10/17/26, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111453
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 10/17/26, 12:14
-
Benjamin Franzke commented on patch set 2 10/19/26, 09:52
-
Benjamin Kott rebased onto patch set 3
CR +1V +110/19/26, 14:51 -
core-ci voted on patch set 3 V +1 10/19/26, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111661
-
Benjamin Kott uploaded patch set 4
V +110/20/26, 19:07 -
core-ci voted on patch set 4 V -1 10/20/26, 19:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111925
-
Garvin Hicking commented on patch set 4 10/20/26, 19:32
GraphicalFunctions.php:460What about png/heic/gif? Svg even? -
Benjamin Kott rebased onto patch set 5
V -110/20/26, 21:10 -
core-ci voted on patch set 5 V -1 10/20/26, 21:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111938
-
Benjamin Kott uploaded patch set 6
V -110/20/26, 21:59 -
Benjamin Kott commented on patch set 6 10/20/26, 22:12
GraphicalFunctions.php:460ReplySVG (targetfile) is not processed in the chain here, as the scaling is handled differently. The CMD map before already had the current restrictions in place. Only the processing was moved and adjusted. png and gif target files were never sharpened, png and gif are lossless and adding sharpening would add halos. lossy formats are handled here as before. -
Benjamin Kott commented on patch set 6 10/20/26, 22:13
DefaultConfigurationDescription.yaml:27Replyas discussed, adjusted -
core-ci voted on patch set 6 V +1 10/20/26, 22:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111943
-
Garvin Hicking commented on patch set 6 CR +1 V +1 10/21/26, 09:13
GraphicalFunctions.php:460ReplyAcknowledged -
Benjamin Kott voted on patch set 6 CR +2 V +2 10/21/26, 09:14
-
Benjamin Kott merged patch set 7 10/21/26, 09:14
DefaultConfigurationDescription.yaml:27