Review main Merged Breaking

96780[!!!][TASK] Rename GFX/processor_effects to GFX/sharpen

Benjamin Kott CR +2 V +2 Hard +214 −103 updated 10/21/26, 09:14

Commit message

GFX/processor_effects only ever made ImageMagick and GraphicsMagick
sharpen scaled JPEG, WebP and AVIF images, while its description
claimed it enabled blurring and sharpening. Its -sharpen 1x2 hardened
edges noticeably and made the files about a quarter larger, and it also
sharpened scaled-up images, which gain next to nothing from it.

It is renamed to GFX/sharpen and stays a global switch, enabled by
default and in both image processor presets. It now applies the lighter
-unsharp 1x2+0.25+0, and only to images that are scaled down. Which
formats are sharpened does not change: JPEG, WebP and AVIF, as before,
and never PNG or GIF. The silent configuration upgrade migrates the
setting.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 1420

  1. Benjamin Kott uploaded patch set 1 10/17/26, 09:53

  2. core-ci voted on patch set 1 V +1 10/17/26, 10:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111442

  3. Benjamin Kott rebased onto patch set 2 V +1 10/17/26, 11:55

  4. core-ci voted on patch set 2 V +1 10/17/26, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111453

  5. Simon Schaufelberger voted on patch set 2 CR +1 V +1 10/17/26, 12:14

  6. Benjamin Franzke commented on patch set 2 10/19/26, 09:52

    DefaultConfigurationDescription.yaml:27

    Let's check if we can remove this option instead since GM and IM apply a filter when resizing, which probably renders additionally sharpening uneeded: http://www.graphicsmagick.org/GraphicsMagick.html#:~:text=The%20default%20filter%20is%20automatically%20selected%20to%20provide%20the%20best%20quality%20while%20consuming%20a%20reasonable%20amount%20of%20time.%20The%20Mitchell%20filter%20is%20used%20if%20the%20image%20supports%20a%20palette%2C%20supports%20a%20matte%20channel%2C%20or%20is%20being%20enlarged%2C%20otherwise%20the%20Lanczos%20filter%20is%20used The fact that GM and IM configs differed, shows that this setting can probably be removed, since both resize "nicely" by default.
  7. Benjamin Kott rebased onto patch set 3 CR +1 V +1 10/19/26, 14:51

  8. core-ci voted on patch set 3 V +1 10/19/26, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111661

  9. Benjamin Kott uploaded patch set 4 V +1 10/20/26, 19:07

  10. core-ci voted on patch set 4 V -1 10/20/26, 19:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111925

  11. Garvin Hicking commented on patch set 4 10/20/26, 19:32

    GraphicalFunctions.php:460

    What about png/heic/gif? Svg even?
  12. Benjamin Kott rebased onto patch set 5 V -1 10/20/26, 21:10

  13. core-ci voted on patch set 5 V -1 10/20/26, 21:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111938

  14. Benjamin Kott uploaded patch set 6 V -1 10/20/26, 21:59

  15. Benjamin Kott commented on patch set 6 10/20/26, 22:12

    GraphicalFunctions.php:460 Reply

    SVG (targetfile) is not processed in the chain here, as the scaling is handled differently. The CMD map before already had the current restrictions in place. Only the processing was moved and adjusted. png and gif target files were never sharpened, png and gif are lossless and adding sharpening would add halos. lossy formats are handled here as before.
  16. Benjamin Kott commented on patch set 6 10/20/26, 22:13

    DefaultConfigurationDescription.yaml:27 Reply

    as discussed, adjusted
  17. core-ci voted on patch set 6 V +1 10/20/26, 22:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111943

  18. Garvin Hicking commented on patch set 6 CR +1 V +1 10/21/26, 09:13

    GraphicalFunctions.php:460 Reply

    Acknowledged
  19. Benjamin Kott voted on patch set 6 CR +2 V +2 10/21/26, 09:14

  20. Benjamin Kott merged patch set 7 10/21/26, 09:14