96781[BUGFIX] Support enums in Fluid form field ViewHelpers
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php3+6 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SelectViewHelper.php+15 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/ButtonViewHelperTest.php+22 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/CheckboxViewHelperTest.php+44 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/HiddenViewHelperTest.php+27 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/PasswordViewHelperTest.php+27 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/RadioViewHelperTest.php+58 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/SelectViewHelperTest.php+69 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/SubmitViewHelperTest.php+22 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/TextareaViewHelperTest.php+25 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/TextfieldViewHelperTest.php+25 −0
Review log 1113
-
Jan Kornblum uploaded patch set 1 10/17/26, 11:15
-
core-ci voted on patch set 1 V +1 10/17/26, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111447
-
Simon Schaufelberger voted on patch set 1 CR +1 V +1 10/17/26, 11:50
-
Garvin Hicking voted on patch set 1 CR +1 10/17/26, 12:56
-
Garvin Hicking commented on patch set 1 10/17/26, 12:57
-
Jan Kornblum commented on patch set 1 10/17/26, 15:30
AbstractFormFieldViewHelper.php:204ReplyI think enum normalization fits better into AbstractFormFieldViewHelper::convertToPlainValue(), since enum values/names are not persistence identifiers. Handling this in the PersistenceManager would also affect other consumers of that API. This is also consistent with the existing enum handling in SelectViewHelper::getOptionValueScalar(). -
Garvin Hicking commented on patch set 1 10/17/26, 15:45
AbstractFormFieldViewHelper.php:204ReplyUnderstood, I can follow the argumentation. -
Garvin Hicking commented on patch set 1 CR -1 10/20/26, 10:20
on it... -
Garvin Hicking uploaded patch set 2
CR +1V +110/20/26, 11:08 -
core-ci voted on patch set 2 V +1 10/20/26, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111798
-
Garvin Hicking commented on patch set 2 CR +1 V +1 10/20/26, 11:43
Reply
Done -
Oli Bartsch voted on patch set 2 CR +2 V +2 10/20/26, 12:32
-
Oli Bartsch merged patch set 3 10/20/26, 12:41
AbstractFormFieldViewHelper.php:204