Review main Merged

96785[TASK] Deprecate GeneralUtility::getBytesFromSizeMeasurement()

Benni Mack CR +2 V +2 Normal +209 −38 updated 10/17/26, 14:40

Commit message

PHP provides ini_parse_quantity() since PHP 8.2 to convert shorthand
byte values like "128M" into bytes, following the same rules PHP
applies to php.ini settings.

All Core callers reading ini values now use the native function,
including the duplicated helper in the install tool system
environment check, which is removed.

The file size validators of EXT:extbase and EXT:form now use
ini_parse_quantity() as well. Decimal values like "1.5M" are not
supported by PHP and are deprecated for the "minimum" and "maximum"
options; they keep working until TYPO3 v16.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 67

  1. Benni Mack uploaded patch set 1 10/17/26, 12:57

  2. Benni Mack marked it ready for review 10/17/26, 12:58

  3. core-ci voted on patch set 1 V +1 10/17/26, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111457

  4. Benjamin Kott voted on patch set 1 CR +1 V +1 10/17/26, 13:33

  5. Wouter Wolters voted on patch set 1 CR +1 V +1 10/17/26, 14:04

  6. Benni Mack voted on patch set 1 CR +2 V +2 10/17/26, 14:40

  7. Benni Mack merged patch set 2 10/17/26, 14:40