Review main Merged

96786[BUGFIX] Accept uppercase file extensions in FileExtensionValidator

Oli Bartsch CR +2 V +2 Normal +57 −1 updated 10/18/26, 08:27

Commit message

The allowed file extensions are lowercased, the extension of the
uploaded file was not. Files like "photo.JPG" were rejected although
"jpg" is allowed, which affects many uploads from phones and cameras.

The extension is now compared case-insensitively. The error message
keeps the extension as uploaded.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 10/17/26, 13:48

  2. core-ci voted on patch set 1 V +1 10/17/26, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111462

  3. Oliver Klee voted on patch set 1 CR +1 V +1 10/17/26, 17:03

  4. Benni Mack voted on patch set 1 CR +1 V +1 10/18/26, 07:22

  5. Georg Ringer voted on patch set 1 CR +2 V +2 10/18/26, 07:28

  6. Garvin Hicking merged patch set 2 10/18/26, 08:27