Review main Merged

96788[TASK] Cover counting Extbase queries with a SQL statement

Alexander Schnitzler CR +2 V +2 Easy +32 −0 updated 10/18/26, 14:29

Commit message

A query with a custom SQL statement containing a JOIN and a WHERE
clause must report the number of rows the statement returns when
count() is called before the result is iterated, not the row total
of the main table. Add a functional test that pins this behaviour.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Matthias Vogel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Matthias Vogel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. Alexander Schnitzler uploaded patch set 1 10/17/26, 14:05

  2. Alexander Schnitzler wrote 10/17/26, 14:06

    Topic set to extbase
  3. core-ci voted on patch set 1 V -1 10/17/26, 14:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111464

  4. Alexander Schnitzler uploaded patch set 2 V -1 10/17/26, 14:19

  5. core-ci voted on patch set 2 V +1 10/17/26, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111467

  6. Alexander Schnitzler marked it ready for review 10/17/26, 14:39

  7. Matthias Vogel voted on patch set 2 CR +1 V +1 10/17/26, 15:14

  8. Wouter Wolters voted on patch set 2 CR +1 V +1 10/17/26, 15:19

  9. Simon Schaufelberger voted on patch set 2 CR +1 V +1 10/17/26, 16:18

  10. Oliver Klee voted on patch set 2 CR +1 V +1 10/17/26, 17:00

  11. Benni Mack voted on patch set 2 CR +2 V +2 10/18/26, 14:29

  12. Benni Mack merged patch set 3 10/18/26, 14:29