Review main Merged

96791[TASK] Use str_ends_with() for suffix checks

Wouter Wolters CR +2 V +2 Easy +10 −12 updated 10/19/26, 19:23

Commit message

Replace substr() comparisons with str_ends_with() to express suffix
checks directly and avoid creating temporary substrings.

Remove a redundant suffix check already guaranteed by the surrounding
branch. Preserve existing behavior and substring extraction.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Chris Müller +1
    • Oliver Klee +1
    • Alexander Schnitzler +1
    • Matthias Vogel +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Alexander Schnitzler +1
    • Matthias Vogel +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 911

  1. Wouter Wolters uploaded patch set 1 10/17/26, 15:18

  2. Matthias Vogel voted on patch set 1 CR +1 V +1 10/17/26, 15:25

  3. core-ci voted on patch set 1 V -1 10/17/26, 15:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111470

  4. Wouter Wolters uploaded patch set 2 CR +1 V +1 10/17/26, 15:36

  5. core-ci voted on patch set 2 V +1 10/17/26, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111473

  6. Matthias Vogel voted on patch set 2 CR +1 V +1 10/17/26, 15:45

  7. Chris Müller voted on patch set 2 CR +1 10/17/26, 15:47

  8. Alexander Schnitzler voted on patch set 2 CR +1 V +1 10/17/26, 16:49

  9. Oliver Klee voted on patch set 2 CR +1 V +1 10/17/26, 16:56

  10. Garvin Hicking voted on patch set 2 CR +2 V +2 10/19/26, 19:23

  11. Garvin Hicking merged patch set 3 10/19/26, 19:23