Review main Merged

96795[TASK] Use str_starts_with() for prefix checks

Wouter Wolters CR +2 V +2 Easy +20 −20 updated 10/19/26, 19:21

Commit message

Replace substr(), strpos() and boolean strncmp() comparisons with
str_starts_with() to express complete-prefix checks directly.

Preserve the existing validation and matching behavior. Keep the
fixed-length comparison used for IP masks unchanged.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Alexander Schnitzler +1
    • Matthias Vogel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Alexander Schnitzler +1
    • Matthias Vogel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 78

  1. Wouter Wolters uploaded patch set 1 10/17/26, 15:56

  2. Matthias Vogel voted on patch set 1 CR +1 V +1 10/17/26, 15:58

  3. core-ci voted on patch set 1 V +1 10/17/26, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111476

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 10/17/26, 16:13

  5. Alexander Schnitzler voted on patch set 1 CR +1 V +1 10/17/26, 16:39

  6. Oliver Klee voted on patch set 1 CR +1 V +1 10/17/26, 16:59

  7. Garvin Hicking voted on patch set 1 CR +2 V +2 10/19/26, 19:20

  8. Garvin Hicking merged patch set 2 10/19/26, 19:21