96798[TASK] Pin Extbase workspace reads and writes in the conformance suite
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- core-ci +1 CI
Issues 3
Files 1
Review log 911
-
Alexander Schnitzler uploaded patch set 1 10/17/26, 16:44
-
core-ci voted on patch set 1 V +1 10/17/26, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111479
-
Alexander Schnitzler commented on patch set 1 10/17/26, 18:10
This change is ready for review. -
Oliver Klee voted on patch set 1 V +1 10/17/26, 19:15
-
Alexander Schnitzler wrote 10/17/26, 19:47
Topic set to extbase -
Alexander Schnitzler uploaded patch set 2
V +110/18/26, 13:07 -
Alexander Schnitzler commented on patch set 2 10/18/26, 13:10
Patch set 2 only touches LIMIT; the workspace cases are unchanged. - The LIMIT @todo in `workspaceCountAndLimit()` now states the goal: LIMIT applies after the overlay. Fetching twice the limit in a workspace (#105159, change 86370) is an approximation of that goal and can still return fewer rows than the limit. This follows Christian's analysis in #85284: TypoScript `CONTENT` applies LIMIT in SQL before the overlay, which is a known limitation and not a yardstick for Extbase. - New test `limitWithRespectSysLanguageIsAppliedAfterLanguageFiltering()`: with `respectSysLanguage`, the SQL already drops default rows that have no visible translation, so Extbase returns the full limit. It is pinned without a @todo, because this is the intended behaviour. - The @todo for `count()` in a workspace stays as it was. -
core-ci voted on patch set 2 V +1 10/18/26, 13:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111519
-
Oliver Klee voted on patch set 2 V +1 10/18/26, 13:15
-
Benni Mack voted on patch set 2 CR +2 V +2 10/18/26, 14:32
-
Benni Mack merged patch set 3 10/18/26, 14:32